fix(sql): remove sql skip-adding-user question

[xzf0587]

1. remove sql skip-adding-user question.
2. set default skip-adding-user value based on azureAccountProvider?.getIdentityCredentialAsync

[Alive-Fish]

I think it's OK for the most cases, but some corner cases may have problems, such as provisioning in CLI first and then provision in VSCode extension.

[xzf0587]

I think it's OK for the most cases, but some corner cases may have problems, such as provisioning in CLI first and then provision in VSCode extension.

If developers haven't modify the skip-adding-user config in env file, leave it as default. The project will work.
Only specifying the skip-adding-user false in env file will make the cli provision failed.

[wenytang-ms]

it's better merge as a hotfix not a feature

[adashen]

I think it's OK for the most cases, but some corner cases may have problems, such as provisioning in CLI first and then provision in VSCode extension.

If developers haven't modify the skip-adding-user config in env file, leave it as default. The project will work.
Only specifying the skip-adding-user false in env file will make the cli provision failed.

Let's add both test cases and do the verification

[xzf0587]

I think it's OK for the most cases, but some corner cases may have problems, such as provisioning in CLI first and then provision in VSCode extension.

If developers haven't modify the skip-adding-user config in env file, leave it as default. The project will work.
Only specifying the skip-adding-user false in env file will make the cli provision failed.

Let's add both test cases and do the verification

Added the unit test for skip-adding-user.
The e2e test does not support test cli scenario which the identity credential is undefined.

[Alive-Fish]

look good to me

[SLdragon]

Can this be simplified to :

this.config.skipAddingUser = !(await ctx.azureAccountProvider?.getIdentityCredentialAsync())