Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate RPC commands for DEx actions #48

Closed
dexX7 opened this issue May 20, 2015 · 1 comment
Closed

Seperate RPC commands for DEx actions #48

dexX7 opened this issue May 20, 2015 · 1 comment

Comments

@dexX7
Copy link
Member

dexX7 commented May 20, 2015

As discussed in #47 (comment).

Instead of:

sendtrade_OMNI "fromaddress" propertyidforsale "amountforsale" propertiddesired "amountdesired" action

There should be seperate commands for each action, for example:

sendtrade_OMNI "fromaddress" propertyidforsale "amountforsale" propertiddesired "amountdesired"
sendcanceltradebyprice_OMNI "fromaddress" propertyidforsale "amountforsale" propertiddesired "amountdesired"
sendcanceltradebypair_OMNI "fromaddress" propertyidforsale propertiddesired
sendcancelalltrades_OMNI ecosystem

The traditional DEx commands could be seperated in a similar fashion, too.

Edit: bonus points for finding an alternative to the _OMNI suffix. ;)

@zathras-crypto
Copy link

Supported.

Though commands should be eg sendtrade_OMNI rather than sendtrade to match existing naming convention (which I know there is a lack of consensus on _OMNI suffix, but that's probably a different discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants