Fix RegistrationOptions and Capabilities #1025
Merged
+112
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issue found while trying to implement the InlayHint handler (OmniSharp/omnisharp-roslyn#2566). Verified with these changes that the O# LSP will connect to VS Code and InlayHints are provided.
The various custom converters are not available unless we pass along the LSPSerializer.JsonSerializer. This was causing deserialization issues when reading the client capabilities.
InlayHint client capability was missing. Workspace capabilities were incorrectly attached to TextDocumentClientCapabilities. Several Workspace capabilities were keyed off TextDocument.