-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install on MacOS #3
Comments
same here... plz help :-) |
I don't think omnisharp-roslyn server needs dnvm anymore. In addition DNVM has been deprecated in favor of the new dotnet cli UI – see https://github.com/aspnet/dnvm. This brew tap needs to be updated.. I will take a look at this as I am using it on a mac too albeit I built it from sources myself. |
@razzmatazz |
I was looking at it yesterday, and I don't think I have it working yet.. Check out https://github.com/razzmatazz/homebrew-omnisharp-roslyn:
There are two versions of omnisharp on mac os, me myself I am not sure which one is right for .csproj and which one is for .proj/json style projects. Still figuring out what makes my home-built omnisharp work for me rather than the one from releases page/this tap.. Please tell me if any of these versions (from my repo) work! |
Same issue is occurring for me, although I can get
|
@razzmatazz FYI, I installed |
@ylluminarious – yeah, this bugs me too, actually, I don't know why omnisharp-mono release has no startup script–IMHO there should be a one-liner shell script in distro with something like ok my plan is to: |
ok, apparently node client (used for the atom editor) uses however, I wasn't that lucky:
this appears to be a can of worms, lets see if we can figure something out with the help of omnisharp server guys @ylluminarious @LandonSchropp @MadMacMad btw, what clients are you using? emacs, vim? because vscode and atom I think have this figured out automatically? related issues:
|
Yeah, that's because What version of mono are you running? The latest version had changed the assembly loader to have special handling around this assembly. https://github.com/mono/mono/blob/mono-4.8.0-branch/mono/metadata/image.c#L1035-L1091 |
hmm, 4.8, however, the one from mono-project.com, not from brew..
|
That's likely new enough. |
btw, this is binary from v1.12 I see there is v1.13 already, but probably doesn't matter that much which one of those I use |
What happens if you launch OmniSharp.exe with the |
mkay, that works! shame I didn't try it myself
|
@DustinCampbell still my questions are:
|
Yes, probably. 😄
omnisharp-mono.tgz is likely the one to use, and it's better to communicate with it over stdio rather than http (which is the default). omnisharp-osx-x64-netcoreapp1.1.tar.gz is a .NET Core standalone version of OmniSharp that has problems with handling .NET Framework .csproj projects. Eventually, the plan is to just do this: OmniSharp/omnisharp-roslyn#666. |
@razzmatazz Regarding your question about which client I'm using: I'm only using the Emacs one. Thanks for investigating this and providing the extra info. I need omnisharp for my work (lest I use MonoDevelop, lol), so I'm just going to modify |
Hey guys, I've updated the formula to 1.13.0 and removed the outdated dependency on |
@sjrmanning – can you replace -netcoreapp with -mono version on the formula? I think this is how it should be lately. |
@razzmatazz The issue with using the -mono version is it then relies on the user using Edit: It seems like this might have issues on macOS. With the -mono version installed |
@sjrmanning ok, I propose this: a) adding a second formula, b) including a bootstrap file in
If you don't have time or are not able to test – I can try to do a PR. This should keep older users able to use the netcoreapp version and still new users would be able to install omnisharp-mono along too. |
hello, |
@razzmatazz We can definitely add another formula, happy to do that, but does @MadMacMad Can you try install again? The new formula should work for your case, but let me know if you still have any issues. |
@sjrmanning it does crash for me too, if you just run it w/out any args – it tries to run in http mode then, I think, by default.. but specifying |
@razzmatazz I've added an |
@sjrmanning @razzmatazz Thank for the updates and attention to this issue. I just did a fresh install via |
@ylluminarious – I think we can close this issue, works for me too. |
@razzmatazz Fine by me. |
Works for me as well! Thanks guys. |
If you guys wouldn't mind, it would be great to see the readme updated with the new instructions for getting things set up with the |
@LandonSchropp – I think this information is client/editor specific.. |
Going to mark this closed now. I've updated the README to recommend |
Hi I keep getting what is going on? |
@FireAntJoe Homebrew has removed yet another API used in their formulas. They are doing this quite a lot lately; I suppose they hope it will make people's code cleaner, but it's really serving to break lots of stuff. Anyway, this formula is no longer updated. If you're using the Emacs plugin, you should probably use |
@ylluminarious thank you for the information. |
@FireAntJoe It seems that omnisharp-vim has specific instructions for installing the server. They seem to do the same thing as Emacs, except that the extraction and path-setting is done manually. Perhaps you could write a vim function to do it automatically and contribute it to omnisharp-vim? Here is the implementation of |
@ylluminarious no thank you, I stay out of that stuff for a reason lol. |
@FireAntJoe Ok, no problem. |
I'm running into and issue when installing Omnisharp using the instructions in the readme. The command fails with the following output:
The text was updated successfully, but these errors were encountered: