diff --git a/README.md b/README.md index 6980e04bcd..8e7017f852 100644 --- a/README.md +++ b/README.md @@ -10,10 +10,12 @@ OmniSharp-Roslyn is a .NET development platform based on [Roslyn](https://github OmniSharp-Roslyn is built with the [.NET Core SDK](https://dot.net/) on Windows and [Mono](http://www.mono-project.com/) on OSX/Linux. It targets the __net461__ target framework. OmniSharp requires __mono__ (>=5.2.0) if it is run on a platform other than Windows. -For Arch Linux users, need package [msbuild-stable](https://aur.archlinux.org/packages/msbuild-stable/) (>= 15.0) +For Arch Linux users, need package [msbuild-stable](https://aur.archlinux.org/packages/msbuild-stable/) (>= 15.0). In addition, if you need the HTTP interface and you want to run on Linux, you'll also need to make sure that you have [libuv](http://libuv.org) installed. +See also https://github.com/OmniSharp/omnisharp-roslyn/issues/1202#issuecomment-421543905 . + ## What's new See our [change log](https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md) for all of the updates. diff --git a/build.cake b/build.cake index e0706acd61..e5fba2928d 100644 --- a/build.cake +++ b/build.cake @@ -48,7 +48,7 @@ bool AllowLegacyTests() if (platform.IsLinux) { - var version = platform.Version.ToString(); + var version = platform.Version?.ToString(); // Taken from https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0/scripts/obtain/dotnet-install.sh switch (platform.DistroName) @@ -638,8 +638,6 @@ Task("Test") // This is necessary to work around a Mono bug that is exasperated by xUnit. DirectoryHelper.Copy($"{env.Folders.MonoMSBuildLib}", instanceFolder); - DeleteUnnecessaryAssemblies(instanceFolder); - var runScript = CombinePaths(env.Folders.Mono, "run"); // By default, the run script launches OmniSharp. To launch our Mono runtime @@ -655,25 +653,6 @@ Task("Test") } }); -/// -/// Delete assemblies that are included in our Mono package. -/// -void DeleteUnnecessaryAssemblies(string folder) -{ - FileHelper.Delete(CombinePaths(folder, "System.AppContext.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Numerics.Vectors.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Runtime.InteropServices.RuntimeInformation.dll")); - FileHelper.Delete(CombinePaths(folder, "System.ComponentModel.Primitives.dll")); - FileHelper.Delete(CombinePaths(folder, "System.ComponentModel.TypeConverter.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Console.dll")); - FileHelper.Delete(CombinePaths(folder, "System.IO.FileSystem.Primitives.dll")); - FileHelper.Delete(CombinePaths(folder, "System.IO.FileSystem.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Security.Cryptography.Encoding.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Security.Cryptography.Primitives.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Security.Cryptography.X509Certificates.dll")); - FileHelper.Delete(CombinePaths(folder, "System.Threading.Thread.dll")); -} - void CopyMonoBuild(BuildEnvironment env, string sourceFolder, string outputFolder) { DirectoryHelper.Copy(sourceFolder, outputFolder, copySubDirectories: false); @@ -681,8 +660,6 @@ void CopyMonoBuild(BuildEnvironment env, string sourceFolder, string outputFolde // Copy MSBuild runtime and libraries DirectoryHelper.Copy($"{env.Folders.MSBuild}", CombinePaths(outputFolder, "msbuild")); - // Included in Mono - DeleteUnnecessaryAssemblies(outputFolder); } string PublishMonoBuild(string project, BuildEnvironment env, BuildPlan plan, string configuration)