Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to load a plugin that doesn't exist on disk crashes OmniSharp. #1307

Closed
NTaylorMullen opened this issue Oct 1, 2018 · 0 comments · Fixed by #1827
Closed

Attempting to load a plugin that doesn't exist on disk crashes OmniSharp. #1307

NTaylorMullen opened this issue Oct 1, 2018 · 0 comments · Fixed by #1827

Comments

@NTaylorMullen
Copy link
Contributor

This is an edge case because trying to load a plugin that doesn't exist means that the user did:

  1. Manually deleted the locally downloaded omnisharp and/or the plugin
  2. Initial acquisition was corrupt

I tried fixing this on my own here but for some assembly loading reason it results in the plugin no longer being valid and not being found by the composition host service. I didn't debug too far into things but figured I'd file an issue to raise awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant