Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorconfig support doesn't work when folder contains [] characters #1551

Closed
filipw opened this issue Jul 12, 2019 · 3 comments
Closed

Editorconfig support doesn't work when folder contains [] characters #1551

filipw opened this issue Jul 12, 2019 · 3 comments

Comments

@filipw
Copy link
Member

filipw commented Jul 12, 2019

My root folder ${workspaceFolder} name [Foo] bar contains the characters []. If I rename to foobar, everything will work.

  1. create folder [Foo] bar & open
  2. dotnet new console -n Proj1
  3. put .editorconfig
  4. open via VSCode [Foo] bar folder
  5. no warning

Originally posted by @ExceptionGit in #1526 (comment)

@filipw
Copy link
Member Author

filipw commented Jul 12, 2019

We actually use an external component - Microsoft.VisualStudio.CodingConventions to do editorconfig settings discovery, and it's really a bug there.
In fact, I just checked, it doesn't work in Visual Studio too.

@MrFoxPro
Copy link

MrFoxPro commented May 4, 2020

We actually use an external component - Microsoft.VisualStudio.CodingConventions to do editorconfig settings discovery, and it's really a bug there.
In fact, I just checked, it doesn't work in Visual Studio too.

Could you please share how did your configure omnisharp to work with Microsoft.VisualStudio.CodingConventions?

@filipw
Copy link
Member Author

filipw commented Jun 6, 2020

this has been resolved by moving to Roslyn's native editorconfig support

@filipw filipw closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants