Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume Quick Info APIs #1808

Closed
RikkiGibson opened this issue May 22, 2020 · 6 comments
Closed

Consume Quick Info APIs #1808

RikkiGibson opened this issue May 22, 2020 · 6 comments
Labels
feature request

Comments

@RikkiGibson
Copy link

It appears the reading experience when using OmniSharp is somewhat limited because OmniSharp is not using the Quick Info APIs provided by Roslyn.

VS quick info example

OmniSharp quick info-like example
@filipw
Copy link
Member

filipw commented May 25, 2020

yeah this is definitely on the TODO. when we started it didn't exist yet 😀

@333fred
Copy link
Contributor

333fred commented Jul 25, 2020

@filipw this can be closed now :)

@filipw
Copy link
Member

filipw commented Jul 25, 2020

indeed!

@filipw filipw closed this as completed Jul 25, 2020
@RikkiGibson
Copy link
Author

RikkiGibson commented Jul 26, 2020 •
edited
Loading

Is there recent work implementing this? edit: ahh looks like #1860, thanks @333fred

@RikkiGibson
Copy link
Author

@333fred wasn't sure where to follow up with this part-- seems like the nullable flow state bit and the doc comment bit don't always format quite right with the new quick info feature.

image

I think we expect more space between the doc comment and the nullable flow state text. Here's how a similar Quick Info looks in VS:

image

@333fred
Copy link
Contributor

333fred commented Aug 19, 2020

@RikkiGibson open a new bug :)

@RikkiGibson RikkiGibson mentioned this issue Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filipw @333fred @RikkiGibson