Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Inline Parameter Name Hints #1932

Closed
filipw opened this issue Sep 4, 2020 · 5 comments · Fixed by dotnet/vscode-csharp#5107
Closed

Add support for Inline Parameter Name Hints #1932

filipw opened this issue Sep 4, 2020 · 5 comments · Fixed by dotnet/vscode-csharp#5107

Comments

@filipw
Copy link
Member

filipw commented Sep 4, 2020

This is a new feature in VS 2019 16.8 Preview

It is backed by a (fully internal at the moment) CSharpInlineParameterNameHintsService.

@filipw
Copy link
Member Author

filipw commented Oct 7, 2020

while it would be easy to add it to the server side, I am not convinced how useful this will be for the editors. For example VS Code does not currently have any official API to consume this microsoft/vscode#16221

@Kingwl
Copy link

Kingwl commented Feb 8, 2021

Hey folks.

microsoft/vscode#113285 has been merged and seems we could provide the inlineHints now!

@somedeveloperhappy
Copy link

any updates yet?

@filipw
Copy link
Member Author

filipw commented Mar 10, 2022

We have been blocked by this dotnet/roslyn#59941

333fred added a commit to 333fred/vscode-csharp that referenced this issue Mar 16, 2022
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. Tests still need to be written.
@333fred
Copy link
Contributor

333fred commented Mar 16, 2022

Now that vscode's API has been finalized (wasn't done until the 1.65 release a week or two ago) and the LSP spec has been finalized (around the same time), we can add support for the feature. Server support is #2357, and vscode support is dotnet/vscode-csharp#5107. See the vscode PR for a couple of screenshots of what this will look like.

333fred added a commit to 333fred/vscode-csharp that referenced this issue Mar 25, 2022
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. Tests still need to be written.
333fred added a commit to dotnet/vscode-csharp that referenced this issue Mar 29, 2022
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. The extension will require 1.65 going forward, as the API for inlay hints was stablized in this release.

Co-authored-by: Joey Robichaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants