-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Inline Parameter Name Hints #1932
Comments
while it would be easy to add it to the server side, I am not convinced how useful this will be for the editors. For example VS Code does not currently have any official API to consume this microsoft/vscode#16221 |
Hey folks. microsoft/vscode#113285 has been merged and seems we could provide the inlineHints now! |
any updates yet? |
We have been blocked by this dotnet/roslyn#59941 |
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. Tests still need to be written.
Now that vscode's API has been finalized (wasn't done until the 1.65 release a week or two ago) and the LSP spec has been finalized (around the same time), we can add support for the feature. Server support is #2357, and vscode support is dotnet/vscode-csharp#5107. See the vscode PR for a couple of screenshots of what this will look like. |
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. Tests still need to be written.
Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. The extension will require 1.65 going forward, as the API for inlay hints was stablized in this release. Co-authored-by: Joey Robichaud <[email protected]>
This is a new feature in VS 2019 16.8 Preview
It is backed by a (fully internal at the moment) CSharpInlineParameterNameHintsService.
The text was updated successfully, but these errors were encountered: