Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix All always does the entire project, regardless of input #1960

Closed
333fred opened this issue Sep 27, 2020 · 0 comments · Fixed by #1962
Closed

Fix All always does the entire project, regardless of input #1960

333fred opened this issue Sep 27, 2020 · 0 comments · Fixed by #1962

Comments

@333fred
Copy link
Contributor

333fred commented Sep 27, 2020 •
edited
Loading

omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Refactoring/RunFixAllCodeActionService.cs

Line 81 in ed3d417

Microsoft.CodeAnalysis.CodeFixes.FixAllScope.Project,

This ignores the input fix all scope, and always runs fixers over the entire project, regardless of whether just one document is requested.

Example of the behavior:

  1. Create a new WPF app with dotnet new wpf.
  2. Open in vscode
  3. Open Main.xaml.cs
  4. Run "Fix all in document" on unused usings.

Expected:

App.xaml.cs is not touched.

Actual:

Unused usings are removed from App.xaml.cs as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple FixAll from the workspace 333fred/omnisharp-roslyn
1 participant
@333fred