Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly order Code Actions #758

Closed
DustinCampbell opened this issue Feb 8, 2017 · 5 comments
Closed

Properly order Code Actions #758

DustinCampbell opened this issue Feb 8, 2017 · 5 comments
Labels
fixed

Comments

@DustinCampbell
Copy link
Contributor

Today, code actions are ordered with some very suspicious logic.

Roslyn defines an ExtensionOrderAttribute that is applied to code fixes to allow them to state their order dependencies. OmniSharp should use this to create a sensible order.
@DustinCampbell DustinCampbell mentioned this issue Feb 8, 2017
Closed
@david-driscoll
Copy link
Member

... hey the .Reverse() usually orders them in alphabetical order... 👍

@DustinCampbell
Copy link
Contributor Author

😄

@filipw
Copy link
Member

filipw commented Mar 9, 2017 •
edited
Loading

would be great if the ExtensionOrderer was public

@DustinCampbell
Copy link
Contributor Author

Yeah, I know. It's a bit silly.

@akshita31 akshita31 mentioned this issue Jan 2, 2018
Merged
@akshita31
Copy link
Contributor

This issue has been fixed in the 1.14 milestone. We just released a beta of 1.14 - https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.14.0-beta4. Follow these instructions to install a beta release of C# for VS Code.

@filipw filipw mentioned this issue Aug 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DustinCampbell @david-driscoll @filipw @akshita31