Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IgnoreCorLibraryDuplicatedTypes reflection from scripting once CoreFx deals with duplicate types correctly #786

Open
filipw opened this issue Mar 1, 2017 · 1 comment

Comments

@filipw
Copy link
Member

filipw commented Mar 1, 2017

This is a tech debt tracking issue.

Due to the fact scripting works mainly with implementation assemblies since the reference assemblies are not available, it is possible we end up in situations when error CS0433 is incorrectly reported for Corlib. (#784)

At the moment this is solved via reflection (see PR #785).
However this can be cleaned up in the long term, when the underlying issue is resolved in CoreFx (https://github.com/dotnet/corefx/issues/5540 - the duplicates will be marked internal) - obviously we don't want to carry reflection based code.

@filipw
Copy link
Member Author

filipw commented Mar 1, 2017

Flagging as blocked until the solution is available in CoreFx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant