-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload and update MSBuild projects in response to dotnet restore #1003
Merged
DustinCampbell
merged 11 commits into
OmniSharp:master
from
DustinCampbell:package-restore
Nov 6, 2017
Merged
Reload and update MSBuild projects in response to dotnet restore #1003
DustinCampbell
merged 11 commits into
OmniSharp:master
from
DustinCampbell:package-restore
Nov 6, 2017
Commits on Nov 1, 2017
-
Properly add/remove metadata references in MSBuild project system
I recently noticed an issue that has likely been present for a long while. Essentially, metadata references are never removed from the workspace. The reason for this is because Roslyn's MetadataReference class does not implement value equality -- it just inherits the default `Equals()`/`GetHashCode()` implementations from `System.Object`. However, the algorithm for adding and removing metadata references assumes value equality. This is easily fixed by adding our own `IEqualityComparer<MetadataReference>` that first checks to ensure that `MetadataReferences` are `PortableExecutableMetadataReferences` and then uses their file paths for equality.
Configuration menu - View commit details
-
Copy full SHA for 17fa11d - Browse repository at this point
Copy the full SHA 17fa11dView commit details
Commits on Nov 2, 2017
-
Refactor file watching/notification
This change unifies file and directory watching, separates watching and notification concerns in the API, and fixes the following issues: 1. Paths are treated case-insensitively as they are in the rest of OmniSharp. 2. Access to the internal dictionary of callbacks is synchronized.
Configuration menu - View commit details
-
Copy full SHA for 797455a - Browse repository at this point
Copy the full SHA 797455aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a38a707 - Browse repository at this point
Copy the full SHA a38a707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2560f7a - Browse repository at this point
Copy the full SHA 2560f7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 941d52e - Browse repository at this point
Copy the full SHA 941d52eView commit details -
Introduce ProjectManager class to manage MSBuild project files
This is a pretty substantial change that reworks the core logic of the MSBuild project system to enable an important scenario: updating a project when several files change in quick succession. In order to fix an issue with OmniSharp not reloading and updating a project in response to a 'dotnet restore', we must watch four files that might be touched during a restore: * project.asset.json * <project-file>.nuget.cache * <project-file>.nuget.g.props * <project-file>.nuget.g.targets To ensure that we don't reload and update a project multiple times in response to multiple file changes, this PR introduces a simple queue and processing loop using a TPL DataFlow BufferBlock.
Configuration menu - View commit details
-
Copy full SHA for 114148e - Browse repository at this point
Copy the full SHA 114148eView commit details
Commits on Nov 3, 2017
-
Thread 'auto restore' through MSBuild project manager
Previously, we tracked whether a project update *could* invoke an automatic 'dotnet restore' and this PR adds that back. Essentially, we allow auto restore in all cases that a project is updated *except* when the update comes via a restore.
Configuration menu - View commit details
-
Copy full SHA for 18a8854 - Browse repository at this point
Copy the full SHA 18a8854View commit details -
Configuration menu - View commit details
-
Copy full SHA for e79151c - Browse repository at this point
Copy the full SHA e79151cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4f8071 - Browse repository at this point
Copy the full SHA b4f8071View commit details
Commits on Nov 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7315995 - Browse repository at this point
Copy the full SHA 7315995View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8befe87 - Browse repository at this point
Copy the full SHA 8befe87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.