-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back code that sets MSBuildSDKsPath environment variable for each project #1021
Add back code that sets MSBuildSDKsPath environment variable for each project #1021
Conversation
Thanks! |
@DustinCampbell can you also apply this change to the omnisharp-vscode project? |
Yes. It will take time though. These builds go through some process and get uploaded to a couple of different CDNs first. |
Have you ever been able to repro the reliability issue? |
I haven't been able to repro it at all, but there are enough reports that I want to add this back in the meantime. |
I suspect dotnet/msbuild#2532 is different by the way. See my comments there. |
Yeah, I saw that. This issue has me a bit mystified though. We don't do anything special with the SdkResolvers -- just copy them in place. Then, we just use standard MSBuild APIs to evaluate and build a project. No funny business. 😀 Users are reporting problems on multiple OSs. |
Unfortunately, it seems that there are some reliability issues with the MSBuild SDK Resolvers that we haven't gotten to the bottom of yet. So, I'm adding back code to set the
MSBuildSDKsPath
environment variable per project based on running thedotnet
in that project's directory.This should address issues like dotnet/vscode-csharp#1849 and dotnet/vscode-csharp#1846.
Note that this is not a long term solution. It will work for now, but there are several future concerns that we need to be mindful of:
dotnet --info
output changes such thatBase Path
no longer appears in the text, this will break and need to be updated.cc @nguerrera, @livarcocc