Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OmniSharp to latest MSBuild #1145

Merged
merged 3 commits into from
Apr 6, 2018

Commits on Apr 5, 2018

  1. Update OmniSharp to latest MSBuild

    This change updates OmniSharp with the latest MSBuild binaries. Recent performance changes for MSBuild now
    require NuGet.Build.Tasks, which requires a set of NuGet binaries be included as well. Because the versions of these NuGet binaries might be different (actually, they *are* different) than the binaries that OmniSharp uses, there's a bit of duplication.
    DustinCampbell committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    937a39a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    357addb View commit details
    Browse the repository at this point in the history
  2. Set 'BypassFrameworkInstallChecks' MSBuild property when running on Mono

    'BypassFrameworkInstallChecks' allows builds to skip a particularly hacky check in the GetReferenceAssemblyPaths
    task. This hack affects projects that target a .NET Framework version less than 4.0. Essentially, the hack tries
    to load a certain assembly from the GAC to "guarantee" that .NET Framework 3.5 SP1 is installed (an old case added
    specifically for WPF projects). However, we don't include that assembly in our Mono package. So, many Unity projects
    end up failing the check because they often target much early .NET Framework versions. We can fix that by just
    skipping the check, which isn't really necessary when we're running on Mono.
    DustinCampbell committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    11ab9d6 View commit details
    Browse the repository at this point in the history