Return the stdout messages to improve test logging #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2018
rchande
approved these changes
May 25, 2018
| ErrorStackTrace = testResult.ErrorStackTrace | ||
| ErrorStackTrace = testResult.ErrorStackTrace, | ||
| StdOutMessages = testResult.Messages | ||
| .Where(message => message.Category == TestResultMessage.StandardOutCategory) |
There was a problem hiding this comment.
Should we be picking up standard error here too?
| @@ -6,5 +6,6 @@ public class DotNetTestResult | |||
| public string Outcome { get; set; } | |||
| public string ErrorMessage { get; set; } | |||
| public string ErrorStackTrace { get; set; } | |||
| public string[] StdOutMessages {get; set; } | |||
rchande
reviewed
May 25, 2018
| @@ -6,6 +6,7 @@ public class DotNetTestResult | |||
| public string Outcome { get; set; } | |||
| public string ErrorMessage { get; set; } | |||
| public string ErrorStackTrace { get; set; } | |||
| public string[] StdOutMessages {get; set; } | |||
| public string[] StandardOutputMessages { get; set; } | |||
rchande
reviewed
May 25, 2018
| @@ -240,7 +240,12 @@ public override RunTestResponse RunTest(string[] methodNames, string testFramewo | |||
| MethodName = testResult.TestCase.FullyQualifiedName, | |||
| Outcome = testResult.Outcome.ToString().ToLowerInvariant(), | |||
| ErrorMessage = testResult.ErrorMessage, | |||
| ErrorStackTrace = testResult.ErrorStackTrace | |||
| ErrorStackTrace = testResult.ErrorStackTrace, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet test also prints the stdout messages. So added a property to
DotNetTestResultto return an array of these messages.omnisharp-vscode side : dotnet/vscode-csharp#2343
Please review : @rchande @DustinCampbell