-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce configuration for "Go to Symbol in Workspace" #1284
Introduce configuration for "Go to Symbol in Workspace" #1284
Conversation
The related commit on vscode side: dotnet/vscode-csharp#2487 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Some thoughts...
src/OmniSharp.Roslyn.CSharp/Services/Navigation/FindSymbolsService.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Roslyn.CSharp/Services/Navigation/FindSymbolsService.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Abstractions/Models/v1/FindSymbols/FindSymbolsRequest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're changing the behavior of the FindSymbols endpoint, I think we do need to version it.
src/OmniSharp.Cake/Services/RequestHandlers/Navigation/FindSymbolsHandler.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Cake/Services/RequestHandlers/Navigation/FindSymbolsHandler.cs
Outdated
Show resolved
Hide resolved
@rchande @akshita31 I somehow missed this PR before.. what is the reason for this specific check doesn't make much sense, we are validating sender's input, based on sender's condition.. https://github.com/OmniSharp/omnisharp-roslyn/pull/1284/files#diff-030b76f11f6d3bc42e70a3cde2a74be9R24 I think the min length should be implemented on the client side in the VS Code extension, and here we could at best have a global setting that would come from |
@filipw Agreed. Apologies that this got missed out somehow. |
@filipw Thanks for the feedback! |
I already sent a PR here dotnet/vscode-csharp#2625 |
Allow configuring number of chars user must to type in for "Go to Symbol in Workspace" command to return any results (default is 0 to preserve existing behavior). The reasoning here is that when lots of projects are loaded by OmniSharp it makes little sense to return all symbols discovered. This change should largely address these issues as well: #1243, dotnet/vscode-csharp#1808.
Additionally allow configuring max number of items returned by "Go to Symbol in Workspace" command. Similarly to the above in a big repo returning pages and pages of items in most cases will be wasteful. But default is 0 which is indicates no limit to preserve existing behavior.