Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all providers support #1581

Merged
merged 104 commits into from
Jul 30, 2020

Conversation

savpek
Copy link
Contributor

@savpek savpek commented Aug 11, 2019

Fix all providers implementation.

Fix one or all issues in document, project and solution scope.

Todo:

  • Fixes, tweaks, additional tests etc.
  • Using handling seems to require special case, it is very common thing that wanted to be auto fixed so it should be done before initial release.
  • Roslynator fixes doesn't work for some reason. Underlaying issue probably affects many custom providers and not only roslynator.
  • Fix flaky behavior on fix all issues on document.

Supports:

  • Fix one category (by ID) to fix in document, project and solution scope.
  • Fix all autofixable issues in document scope.

Document scope
fix_onebyone_document

Project scope
fix_one_by_one_project

Solution scope:
solution_scope_fix

Fix all issues on document when saved at vscode:

autofix_on_save

savpek added 30 commits July 9, 2019 14:13
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's good to go 😄

@filipw
Copy link
Member

filipw commented Feb 28, 2020

thanks!!

@dnfclas
Copy link

dnfclas commented Mar 11, 2020

CLA assistant check
All CLA requirements met.

@savpek
Copy link
Contributor Author

savpek commented Jun 5, 2020

@filipw any progress with this? Could be nice to get vscode side implemented after this is merged 😄

@loligans
Copy link

@savpek Curious if this is waiting on anything to merge?

@david-driscoll
Copy link
Member

@savpek I think we just forgot about it... let me get these conflicts resolved and I we can :shipit:

@david-driscoll
Copy link
Member

The windows test failure has be confused honestly. I clearly works on mac/linux and it fails somewhere deep in the bowles of roslyn.

@david-driscoll david-driscoll merged commit f7c6f88 into OmniSharp:master Jul 30, 2020
@david-driscoll
Copy link
Member

As always thanks @savpek sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants