Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly use cancellation token in Metadata service #1631

Merged
merged 2 commits into from
Oct 12, 2019
Merged

correctly use cancellation token in Metadata service #1631

merged 2 commits into from
Oct 12, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Oct 11, 2019

GetAndAddDocumentFromMetadata doesn't respect the passed-in cancellation token.

bjorkstromm
bjorkstromm approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@david-driscoll david-driscoll merged commit 538a732 into OmniSharp:master Oct 12, 2019
@filipw filipw deleted the bugfix/metadata-cancellation branch May 12, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@david-driscoll david-driscoll david-driscoll approved these changes

@rchande rchande Awaiting requested review from rchande

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipw @david-driscoll @bjorkstromm