-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the minimal MSBuild to better support .NET 5 Previews #1746
Conversation
you should update here too https://github.com/OmniSharp/omnisharp-roslyn/blob/master/build/Packages.props#L6-L7 |
OK. I've learned a lot today trying to update the NuGet version in Packages.props. It effectively becomes the low version of which SDKs are supported. The current version of 5.2.0 is good because that lines up with the 2.1.x SDK which is LTS. Setting the version above 5.3.0 causes MissingMethod exceptions during design time builds similar to dotnet/core#3402. This makes sense because the global.json used sets the SDK to 3.0.100 which uses 5.3.0. So for the time being, I left the NuGet version as is. Wonder if we effectively need a NuGetLocator ( ala MSBuildLocator ) that loads the NuGet dependencies from the MSBuild path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see, thanks a lot. |
It is still listed as 16.4 while it actually is 16.5
I think a change similar to this commit needs to be done? 77c4cd3 |
Update the msbuild components to match 16.5 releases. Update the nuget components to a preview that supports the net5.0 tfm.
Tested the minimal MSBuild with a .NET 5.0 Preview 2 app on both Windows and MacOS (Mono 6.8.0).
Resolves dotnet/vscode-csharp#3653