Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimal MSBuild to better support .NET 5 Previews #1746

Merged
merged 9 commits into from
Mar 25, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Mar 24, 2020

Update the msbuild components to match 16.5 releases. Update the nuget components to a preview that supports the net5.0 tfm.

Tested the minimal MSBuild with a .NET 5.0 Preview 2 app on both Windows and MacOS (Mono 6.8.0).

Resolves dotnet/vscode-csharp#3653

@filipw
Copy link
Member

filipw commented Mar 24, 2020

@JoeRobich
Copy link
Member Author

JoeRobich commented Mar 25, 2020

you should update here too https://github.com/OmniSharp/omnisharp-roslyn/blob/master/build/Packages.props#L6-L7

OK. I've learned a lot today trying to update the NuGet version in Packages.props. It effectively becomes the low version of which SDKs are supported. The current version of 5.2.0 is good because that lines up with the 2.1.x SDK which is LTS.

Setting the version above 5.3.0 causes MissingMethod exceptions during design time builds similar to dotnet/core#3402. This makes sense because the global.json used sets the SDK to 3.0.100 which uses 5.3.0.

So for the time being, I left the NuGet version as is. Wonder if we effectively need a NuGetLocator ( ala MSBuildLocator ) that loads the NuGet dependencies from the MSBuild path.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipw
Copy link
Member

filipw commented Mar 25, 2020

I see, thanks a lot.

@filipw filipw merged commit 004e737 into OmniSharp:master Mar 25, 2020
@stijnherreman
Copy link

stijnherreman commented Jun 18, 2020

It is still listed as 16.4 while it actually is 16.5

[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Visual Studio Community 2019 16.5.30104.148 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"
            2: StandAlone 16.4 - "c:\Users\stijn\.vscode\extensions\ms-dotnettools.csharp-1.22.1\.omnisharp\1.35.3\.msbuild\Current\Bin"
PS C:\Users\stijn\.vscode\extensions\ms-dotnettools.csharp-1.22.1\.omnisharp\1.35.3\.msbuild\Current\Bin> .\MSBuild.exe -version
Microsoft (R) Build Engine version 16.5.0+d4cbfca49 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

16.5.0.12403

I think a change similar to this commit needs to be done? 77c4cd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OmniSharp.MSBuild.ProjectManager Support to .NET 5
3 participants