Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for WarningsAsErrors msbuild property #1779

Merged
merged 7 commits into from
May 4, 2020
Merged

added support for WarningsAsErrors msbuild property #1779

merged 7 commits into from
May 4, 2020

Conversation

filipw
Copy link
Member

@filipw filipw commented May 4, 2020

WarningsAsErrors is a list of warnings that should be treated as errors.
TreatWarningsAsErrors is the boolean that lifts all warnings to errors.

We never supported WarningsAsErrors, only TreatWarningsAsErrors

JoeRobich
JoeRobich approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjorkstromm bjorkstromm merged commit 098b634 into master May 4, 2020
@bjorkstromm bjorkstromm deleted the feature/warnings-as-errors branch May 4, 2020 21:02
@filipw filipw mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipw @JoeRobich @bjorkstromm