Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use global property when resetting TargetFramework #1846

Merged
merged 3 commits into from
Jul 2, 2020
Merged

use global property when resetting TargetFramework #1846

merged 3 commits into from
Jul 2, 2020

Conversation

filipw
Copy link
Member

@filipw filipw commented Jun 29, 2020

@filipw
Copy link
Member Author

filipw commented Jun 29, 2020

👏 thanks @ericstj 👏

@ericstj
Copy link

ericstj commented Jun 29, 2020

Thank you for the fix @filipw. This will improve the experience for folks using VS code to develop in dotnet/runtime. cc @ViktorHofer @Anipik

@JoeRobich JoeRobich merged commit d0ff417 into OmniSharp:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intellisense Gets Broken in vscode if we have some derived properties from TFM
4 participants
@filipw @ericstj @JoeRobich @bjorkstromm