Added support for 'extract base class' #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
changed the title
JoeRobich
approved these changes
Oct 2, 2020
src/OmniSharp.Roslyn/WorkspaceServices/ExtractClassWorkspaceService.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Roslyn/WorkspaceServices/ExtractClassWorkspaceService.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Roslyn/WorkspaceServices/ExtractClassWorkspaceService.cs
Outdated
Show resolved
Hide resolved
| { | ||
| }"; | ||
|
|
||
| // TODO: this refactoring was renamed to 'Extract base class...' in latest Roslyn |
There was a problem hiding this comment.
for the next lucky winner that updates Roslyn 😀
Co-authored-by: Joey Robichaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature in Roslyn, just added this August.
It doesn't light up for us because it requires UI option interaction. This PR adds some reasonable defaults and a dispatch proxy to implement the internal interface - following similar model to what we have in e.g. extract interface already.
Note that the name of the refactoring will change when we pull in new Roslyn build. It's currently
Pull member(s) up to new base class...but in the new build it's already renamed toExtract base class...