When an analyzer fails to load, log an error #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
thanks, makes sense. there is a somewhat related thing to it that for code actions that come from predefined assemblies (roslyn features. roslynator etc) we currently ignore those with generics (in case you'd wonder why something should light up but it doesn't)
Right now we just silently fail which isn't a good debugging experience. Ideally these would be shown in the error list but this is good enough when trying to track things down.
jasonmalinowski
force-pushed
the
log-analyzer-loading-errors
branch
from
c8bb279
to
c1dff07
Compare
JoeRobich
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we just silently fail which isn't a good debugging experience. Ideally these would be shown in the error list but this is good enough when trying to track things down.