Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnisharp now uses libPaths and sourcePaths defined in custom .rsp file #2000

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

ByronMayne
Copy link
Contributor

@ByronMayne ByronMayne commented Nov 3, 2020

This values were always being parsed but they were not being used. Here is an example of a .rsp file that I am using

# Core References
/using:System
/using:System.Core
/using:Microsoft.CSharp
/using:System
/using:System.IO
/using:System.Collections.Generic
/using:System.Console
/using:System.Diagnostics
/using:System.Dynamic
/using:System.Linq
/using:System.Linq.Expressions
/using:System.Text
/using:System.Threading.Tasks

/loadPaths:C:\\Users\\byron\\Desktop\\scriptingIncludes

@dnfadmin
Copy link

dnfadmin commented Nov 3, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good thanks. I would ask for some tests but we don't have any for RSP at the moment, so it's fine 😃

@filipw filipw merged commit 6d5fbe6 into OmniSharp:master Nov 4, 2020
@ByronMayne
Copy link
Contributor Author

Oh awesome, I thought it was going to be discussion instead of approved right away!

Right now the json schmea for omni sharp does not have a member defined for the rspFilePath field. Where would that be added?

I have a few other minor changes after using this for a bit but I will create another PR.

@filipw
Copy link
Member

filipw commented Nov 4, 2020

Right now the json schmea for omni sharp does not have a member defined for the rspFilePath field. Where would that be added?

it should be PR-ed here -> https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/omnisharp.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants