Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update included build tools to closely match NET 6 Preview 1 SDK #2103

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

JoeRobich
Copy link
Member

No description provided.

@filipw
Copy link
Member

filipw commented Mar 2, 2021

very nice could you also please upgrade the bundled MSBuild to 16.9 as well? It seems to work with .NET 6.0 currently, but it's still 16.8

@JoeRobich
Copy link
Member Author

JoeRobich commented Mar 2, 2021

could you also please upgrade the bundled MSBuild to 16.9 as well? It seems to work with .NET 6.0 currently, but it's still 16.8

This does update the bundled MSBuild.

<package id="Microsoft.Build" version="16.9.0" />
<package id="Microsoft.Build.Framework" version="16.9.0" />
<package id="Microsoft.Build.Runtime" version="16.9.0" />
<package id="Microsoft.Build.Tasks.Core" version="16.9.0" />
<package id="Microsoft.Build.Utilities.Core" version="16.9.0" />

The version in the Packages.props isn't deployed and is just used to compile against.
<PackageReference Include="Microsoft.Build" ExcludeAssets="Runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="Runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build.Tasks.Core" ExcludeAssets="Runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build.Utilities.Core" ExcludeAssets="Runtime" PrivateAssets="all" />

@filipw
Copy link
Member

filipw commented Mar 2, 2021

ah you are right. We used to ship those as separate zips, but I forgot we stopped doing that

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when this is merged, it's a good time to trigger a new release, it's been a while

@JoeRobich
Copy link
Member Author

it's a good time to trigger a new release, it's been a while

I want to follow up this afternoon with a PR to update Roslyn to either our 3.9.0 package or possible 3.10 preview1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants