Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update included build tools to match .NET 6 Preview 7 SDK #2196

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Update included build tools to match .NET 6 Preview 7 SDK #2196

merged 3 commits into from
Jul 27, 2021

Conversation

JoeRobich
Copy link
Member

@captainsafia This change will require updating the Roslyn version you are using in aspnetcore-tooling.

filipw
filipw approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

captainsafia
captainsafia approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be fine. It should be fine to upgrade the Roslyn version in aspnetcore-tooling without updating aspnetcore.

@JoeRobich
Copy link
Member Author

@333fred Can you review this commit f4a6654

333fred
333fred approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do think we'll want tests and to verify what the behavior is, and we'll need to see whether we should keep this provider enabled for regular completion. It's possible it'll slow down standard completion too much.

@JoeRobich JoeRobich merged commit b5d9d7c into OmniSharp:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@captainsafia captainsafia captainsafia approved these changes

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoeRobich @filipw @captainsafia @333fred