Allow net6 build of O# to load newer .NET SDKs #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a spectacular solution and I love how simple it turned out to be! |
filipw
approved these changes
Dec 14, 2021
|
This release would be great. |
waf
added a commit
to waf/CSharpRepl
that referenced
this pull request
Nov 10, 2022
The NuGet.* libraries should not be bundled with csharprepl and we should instead use the ones included in the SDK. You can see other projects in the .NET community making similar fixes: microsoft/qsharp-compiler#1470 OmniSharp/omnisharp-roslyn#2308 OmniSharp/omnisharp-roslyn#2436 If we don't do this, we get issues with the MSBuildWorkspaces and MSBuildLocators unable to load the nuget libraries due to dependency conflicts. It mostly affects our "load solution" / "load project" features.
mattstern31
added a commit
to mattstern31/CSharp-Repl-Services
that referenced
this pull request
Nov 11, 2023
The NuGet.* libraries should not be bundled with csharprepl and we should instead use the ones included in the SDK. You can see other projects in the .NET community making similar fixes: microsoft/qsharp-compiler#1470 OmniSharp/omnisharp-roslyn#2308 OmniSharp/omnisharp-roslyn#2436 If we don't do this, we get issues with the MSBuildWorkspaces and MSBuildLocators unable to load the nuget libraries due to dependency conflicts. It mostly affects our "load solution" / "load project" features.
syedrizvinet
added a commit
to syedrizvinet/Repl-Tests-CSharp
that referenced
this pull request
Apr 24, 2024
The NuGet.* libraries should not be bundled with csharprepl and we should instead use the ones included in the SDK. You can see other projects in the .NET community making similar fixes: microsoft/qsharp-compiler#1470 OmniSharp/omnisharp-roslyn#2308 OmniSharp/omnisharp-roslyn#2436 If we don't do this, we get issues with the MSBuildWorkspaces and MSBuildLocators unable to load the nuget libraries due to dependency conflicts. It mostly affects our "load solution" / "load project" features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not shipping NuGet libraries ourselves in our net6 packages, we will load the NuGet libraries shipped with the SDK registered by the MSBuildLocator. I did need to add a SemanticVersion implementation in order to remove our use of NuGet.Versioning.
To test you can install 6.0.2xx version of the .NET SDK from dotnet/installers.