-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates included build tool to match the current 6.0.200 sdk #2329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
is this
Looks like on Unix we need to include |
|
||
// This issue only affects the MSBuild tools shipped with O# as Mono does not ship | ||
// with a version of MSBuild that includes this change. | ||
Environment.SetEnvironmentVariable("MSBUILDDISABLEFEATURESFROMVERSION", "17.0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is some dark magic man
I think we need to expedite getting rid of the standalone msbuild feature as we discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I opened an issue and it should get resolved for 17.2 (dotnet/msbuild#7335), but not shipping is best path forward.
Includes the changes to completion and block structure options from #2306