fixed constructor signature helper #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here is the fix deployed to VS Code (docs skipped by design here)
|
DustinCampbell
approved these changes
Dec 6, 2016
There was a problem hiding this comment.
Nice! I'm looking forward to just using this some day: dotnet/roslyn#13962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when dealing with constructors, OmniSharp was returning
symbol.ContainingType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat)rather thansymbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat).This resulted in all entries being identical for each constructor.
fixes #697 and fixes dotnet/vscode-csharp#36