Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to VS 2017 RC .NET Core SDK packages #738

Merged
merged 5 commits into from
Jan 30, 2017
Merged

Update to VS 2017 RC .NET Core SDK packages #738

merged 5 commits into from
Jan 30, 2017

Conversation

DustinCampbell
Copy link
Contributor

This PR includes the following changes

  • Update OmniSharp to the latest .NET Core SDK packages
  • Include "ImportAfter" targets which will should allow it to perform package restores via MSBuild in the near feature.
  • Clean up build.cake somewhat (at least, reducing some noise).
  • Add support for setting MSBuildSDKsPath in omnisharp.json. This can be used to redirect OmniSharp to a different set of SDK packages if desired.

david-driscoll
david-driscoll approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DustinCampbell DustinCampbell changed the title Update to VS 2017 .NET Core SDK packages Update to VS 2017 RC .NET Core SDK packages Jan 30, 2017
@DustinCampbell
Copy link
Contributor Author

whoa! Mac CI finishes before AppVeyor kicks off? What strange alternate universe is this?

@DustinCampbell DustinCampbell merged commit e56399e into OmniSharp:dev Jan 30, 2017
@DustinCampbell DustinCampbell deleted the update-sdks branch February 2, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DustinCampbell @david-driscoll @filipw