Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MSBuild environment initialization and allow it to use Visual Studio 2017 if it's present #818

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Clean up MSBuild environment initialization and allow it to use Visual Studio 2017 if it's present #818

merged 1 commit into from
Apr 9, 2017

Commits on Apr 7, 2017

  1. Clean up MSBuild environment initialization and allow it to use Visua… 

    …l Studio 2017 if it's present

Fixes dotnet/vscode-csharp#1368

This change ensures that OmniSharp will use the MSBuild tools installed with Visual Studio 2017 if they're present on the machine. This allows OmniSharp to properly handle VS 2017 projects where the targets/tasks aren't include with OmniSharp's local MSBuild, such as WebApplication projects as reported in the bug listed above. If VS 2017 is not on the machine, OmniSharp will continue to use its local MSBuild which has a fallback to the Microsoft Build Tools for targets/tasks that it can't find.

I've also taken the opportunity to clean up a lot of the MSBuild environment initialized code and project file processing.
    @DustinCampbell
    DustinCampbell committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    5f68289 View commit details
    Browse the repository at this point in the history