-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop deploying SDKs with OmniSharp #847
Conversation
0fa1b58
to
2cdb706
Compare
Note, this also shrinks the drops by a good bit. |
very nice! also the build script should be faster On a side note, I think we should also review what is the role of |
Yes. I've been going through Abstractions and moving things out. For example, a lot of implementations have moved to OmniSharp.Host and OmniSharp.Roslyn. |
Not by much. Restoring these packages and copying their contents was a fairly small amount of time compared to other steps, like publish. |
I use -use-global-dotnet-sdk but the non-existing local SDK path is still referenced in the msbuild.sh script: |
There is an Enviroment property in RunOptions: public IDictionary<string, string> Environment { get; } using this property, the actual SDK_DIR could be passed to msbuild.sh? |
Yes, this should be done. I'm not sure what your comment has to do with this particular PR though. |
I thought the functionality of passing the correct SDK_DIR to msbuild.sh should have been part of this PR, because building on GNU/Linux systems fails if you use this new feature (dont deploy SDK). |
Fixes #765
This change stops deploying the .NET Core MSBuild SDKs with OmniSharp. That was a stop gap for .NET Core 1.0. However, with .NET Core 2.0 around the corner, it's time to stop deploying them and rely on the .NET Core SDK installed on the user's machine.
To locate the correct .NET Core SDK, we simply launch
dotnet --info
in the working directory of the project. That should properly handle the case where the SDK is specified in a global.json file. Then, we process the text returned bydotnet --info
and locate the "Base Path" value. Combining this with "Sdks" should be the correct value.