Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move (back) over to MSBuild solution parsing API #897

Merged
merged 5 commits into from
Jun 27, 2017

Conversation

DustinCampbell
Copy link
Contributor

Fixes dotnet/vscode-csharp#1580

This also adds initial tests for #863.

@filipw
Copy link
Member

filipw commented Jun 27, 2017

great - out of curiosity, what was the original reason for the custom parsing code?

@DustinCampbell
Copy link
Contributor Author

There are a couple of things:

  1. Before, we were using the "project type GUID" to detect Unity projects and such. But I've now handled that through other means. Checking for ".csproj" is good enough.

  2. When I originally tried to use MSBuild's API, I tried to use the "AbsolutePath" property for each project and found that had a bug with non-Windows slashes. Sticking with the "RelativePath" found in the solution file and keeping our existing logic for converting slashes avoids that bug.

@filipw
Copy link
Member

filipw commented Jun 27, 2017

thanks

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DustinCampbell
Copy link
Contributor Author

Thanks guys!

@DustinCampbell DustinCampbell merged commit af1576c into OmniSharp:dev Jun 27, 2017
@DustinCampbell DustinCampbell deleted the msbuild-solution-parser branch August 30, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants