Add logic to set MSBuildExtensionsPath to Mono's xbuild directory #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got additional changes coming for this. |
filipw
approved these changes
Jul 22, 2017
|
I kicked off the build again |
|
@filipw: This isn't ready yet. Got another important change coming that actually fixes this. |
|
👍 |
This includes PR mono/msbuild#22 to fix an issue with TargetFrameworkRootPath fallbacks.
DustinCampbell
force-pushed
the
mono-build-environment
branch
from
e99317f
to
472f30b
Compare
|
@filipw: Do you want to take another look? |
|
looks good! |
|
@filipw: Maybe. I'm not sure that's a very common scenario though. At least, I've never heard an ask for it. |
This was referenced Jul 25, 2017
|
OK. Got one more change to make. |
|
OK. I've done more testing on this today and it seems to work reasonably well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm cherry-picking this change from #915, since it's unrelated to that PR.
Fixes #892
Fixes dotnet/vscode-csharp#1597
Fixes dotnet/vscode-csharp#1624
Fixes dotnet/vscode-csharp#1396
Related PR: mono/msbuild#22