Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code action "Rename file as <class_name>" does nothing #561

Closed
Melandel opened this issue Feb 27, 2020 · 1 comment
Closed

Code action "Rename file as <class_name>" does nothing #561

Melandel opened this issue Feb 27, 2020 · 1 comment

Comments

@Melandel
Copy link
Contributor

Melandel commented Feb 27, 2020

Hello,

I am working on a file Greater that contains a class named Greeter.

The code actions suggest that I rename the file to Greeter.cs.

However, when selecting this code action, a No action taken is echoed.

I would have expected my file to be renamed.

Is there a way to have this behaviour?

I'm working on gvim 8.2 on Windows 10 and did an :OmniSharpInstall this morning as well as a git pull for omnisharp-vim

@nickspoons
Copy link
Member

This is a duplicate of #454.

The answer is that renaming a file is outside OmniSharp-roslyn's scope, so we'll need to do a bit more work on the OmniSharp-vim side. I haven't looked into this but I expect the OmniSharp-roslyn response will contain the new filename, and we should use that to perform the rename. We might be able to take some inspiration from vim-eunuch's :Rename functionality.

I'll close this issue as a duplicate and add this comment to the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants