Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Constructor from another project appears in autocomplete/intellisense. #1664

Closed
bryanwood opened this issue Jul 26, 2017 · 4 comments

Comments

@bryanwood
Copy link

Environment data

dotnet --info output:

.NET Command Line Tools (2.0.0-preview2-006497)

Product Information:
 Version:            2.0.0-preview2-006497
 Commit SHA-1 hash:  06a2093335

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.0.0-preview2-006497\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview2-25407-01
  Build    : 40c565230930ead58a50719c0ec799df77bddee9

VS Code version: 1.14.2
C# Extension version: 1.11.0

Steps to reproduce

Have two projects, one with:

using System;

namespace Lib
{
    public class Class1
    {
        public Class1() { }

        internal Class1(string param) { }
    }
}

and another with

using System;

namespace App
{
    class Program
    {
        static void Main(string[] args)
        {
            var lib = new Lib.Class1();
            var lib2 = new Lib.Class1("param");
        }
    }
}

Expected behavior

Internal ctor is not visible in autocomplete/intellisense.

Actual behavior

Internal ctor is visible in autocomplete intellisense.

It does squiggle the internal ctor as an error if used.

Example here:
https://github.com/bryanwood/omnisharp-vscode-internal-ctor-repro

@DustinCampbell
Copy link
Member

Thanks for reporting this. Much appreciated!

@rchande
Copy link

rchande commented Nov 30, 2017

@akshita31 Another one for you to take a look at.

@akshita31
Copy link
Contributor

akshita31 commented Dec 9, 2017

This issue has been fixed with the change OmniSharp/omnisharp-roslyn#1030 .

@akshita31
Copy link
Contributor

This issue has been fixed in the 1.14 milestone. We just released a beta of 1.14 - https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.14.0-beta4. Follow these instructions to install a beta release of C# for VS Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants