Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: csharp.referencesCodeLens.enabled setting #1807

Closed
mcclure opened this issue Oct 25, 2017 · 4 comments
Closed

Feature request: csharp.referencesCodeLens.enabled setting #1807

mcclure opened this issue Oct 25, 2017 · 4 comments

Comments

@mcclure
Copy link

mcclure commented Oct 25, 2017

Environment data

dotnet --info output:

'dotnet' is not recognized as an internal or external command,
operable program or batch file.

VS Code version: 1.17.2
C# Extension version: 1.12.1
I am testing on Windows 10.

Steps to reproduce

Open "user settings" with ctrl-shift-p. In the search box type "References".

A javascript.referencesCodeLens.enabled and typescript.referencesCodeLens.enabled are found. In other words, it is possible to disable the CodeLens "references" feature selectively for JS/TS only.

There is no csharp.referencesCodeLens.enabled, and manually setting one has no effect. The only way to disable the "N references" display in VS Code is to set editor.codeLens to false. I am not certain what other features (if any) I am disabling by setting editor.codeLens false.

Expected behavior

  • I should be able to disable the "5 references" text which is by default scattered through the code without disabling other features.
  • In my opinion, there should be feature parity between the TypeScript and C# modules. If TypeScript allows you to turn off the "references" display for TypeScript only, so should C#.
@DustinCampbell
Copy link
Member

Thanks! @rchande: Do you want to change the setting you added to match this?

@mcclure
Copy link
Author

mcclure commented Oct 25, 2017

yay

@filipw
Copy link
Contributor

filipw commented Oct 26, 2017

@mcclure this is already available in the latest code (not yet released), but as @DustinCampbell mentioned, the names of these settings are different - csharp.showReferencesCodeLens and csharp.showTestsCodeLens.

It would definitely make sense to standardize them to match other language ecosystems 👍

@rchande
Copy link

rchande commented Oct 26, 2017

Sounds good. I'll update the option names today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants