Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find All References highlight not working #428

Closed
coeyes opened this issue Jun 13, 2016 · 3 comments
Closed

Find All References highlight not working #428

coeyes opened this issue Jun 13, 2016 · 3 comments
Assignees
Milestone

Comments

@coeyes
Copy link

coeyes commented Jun 13, 2016

Environment data

OS X 10.11.5
Mono JIT compiler version 4.4.0
VS Code version: 1.2
C# Extension version: Legacy C# Support 0.33

Steps to reproduce

  1. locate cursor on any variable.
  2. Find All References (Shift + F12)

Expected behavior

highlight on variables

Actual behavior

not highlight.
gamemanager cs - test2d 2016-06-13 14-33-21

Other language project (eg. JavaScript) works correctly. but c# project doesn't working.

@DustinCampbell
Copy link
Member

If I understand correctly, the issue is that the references are not highlighted within the peek window. Is that correct?

@coeyes
Copy link
Author

coeyes commented Jun 15, 2016

yes, this issue is related to the peek window highlight.

I expected below. (from vscode offical homepage)
unity_peekreferences

@DustinCampbell
Copy link
Member

Looks like an issue here: https://github.com/OmniSharp/omnisharp-vscode/blob/v1.7.0-beta5/src/features/referenceProvider.ts#L24. We're only passing the start line and column rather than the full range. Should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants