Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set status bar color to white #4384

Closed
Tyriar opened this issue Feb 7, 2021 · 0 comments · Fixed by #4385
Closed

Do not set status bar color to white #4384

Tyriar opened this issue Feb 7, 2021 · 0 comments · Fixed by #4385

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Feb 7, 2021

Following up from #3138

You should set no color, not white. Otherwise it will be white on light themes and be invisible: https://github.com/OmniSharp/omnisharp-vscode/blob/273c95eea2d9d80aa62d93c4eee5989e474d5ce8/src/observers/OmnisharpStatusBarObserver.ts#L14

See #3138 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid white status bar items to ensure contrast Tyriar/omnisharp-vscode
1 participant
@Tyriar