Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c# code with #region, "" and / formatting issue #731

Closed
dbaeumer opened this issue Aug 29, 2016 · 4 comments
Closed

c# code with #region, "" and / formatting issue #731

dbaeumer opened this issue Aug 29, 2016 · 4 comments
Assignees
@DustinCampbell
Labels
Bug Editor-Syntax Highlighting Resolved-Fixed
Milestone
1.7

Comments

@dbaeumer
Copy link

From @ruchanb on August 29, 2016 11:57

  • VSCode Version: 1.3.1
  • OS Version: Windows 10

Steps to Reproduce:

image

The formatting goes bad when the #region has "" and / on it.

Copied from original issue: microsoft/vscode#11098
@dbaeumer
Copy link
Author

From @ruchanb on August 29, 2016 12:2

I think this issue is to be posted to csharp plugin provider

@dbaeumer dbaeumer mentioned this issue Aug 29, 2016
Closed
@DustinCampbell
Copy link
Member

Thanks for forwarding @dbaeumer!

@ruchanb
Copy link

ruchanb commented Aug 30, 2016

This issue is solved with the latest update 1.4.0.

@DustinCampbell DustinCampbell added this to the 1.7 milestone Jan 7, 2017
@DustinCampbell DustinCampbell self-assigned this Jan 7, 2017
DustinCampbell added a commit to DustinCampbell/vscode-csharp that referenced this issue Jan 7, 2017
@DustinCampbell
Add regression test for issue dotnet#731
ff5455a
@DustinCampbell
Copy link
Member

This should look much better in the next release:

image

@DustinCampbell DustinCampbell mentioned this issue Jan 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DustinCampbell DustinCampbell

Labels
Bug Editor-Syntax Highlighting Resolved-Fixed
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
3 participants
@DustinCampbell @dbaeumer @ruchanb