Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure children of OmniSharp server process are killed on Unix #1466

Merged
merged 1 commit into from
May 17, 2017
Merged

Ensure children of OmniSharp server process are killed on Unix #1466

merged 1 commit into from
May 17, 2017

Conversation

DustinCampbell
Copy link
Member

Fixes #1445

@gregg-miskelly
Copy link
Contributor

One suggestion, which you can take or leave: have OmniSharp exit automatically if its communication (stdin/stdout?) handles are closed. You can still certainly also make this fix as it will help if say mono got itself into a really weird state in initialization. But having it exit automatically can fix the case that our extension process crashed or was killed.

@DustinCampbell
Copy link
Member Author

Good idea!

@DustinCampbell
Copy link
Member Author

OK. I spent a little time working on this, and it's a bit more involved than I'd like, requiring a fair amount of refactoring of the OmniSharpServer code. It's all good and useful refactoring, but it's not important to dig into now. I filed #1488 to add that improvement in the future.

@DustinCampbell DustinCampbell merged commit 53233d3 into dotnet:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DustinCampbell @gregg-miskelly @dnfclas