Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Packages command doesn't work for .NET Framework projects #1507

Closed
adamhartford opened this issue May 23, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@adamhartford
Copy link

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.4)

Product Information:
 Version:            1.0.4
 Commit SHA-1 hash:  af1e6684fd

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.12-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.4

VS Code version: 1.12.2
C# Extension version: 1.9.0

Steps to reproduce

  1. $ dotnet new console
  2. $ code .
  3. In csproj, change TargetFramework to <TargetFramework>net452</TargetFramework>
  4. Choose .NET: Restore Packages from the command palette.

Expected behavior

dotnet restore is executed and packages are restored.

Actual behavior

Error message stating: No .NET Core projects found.

Note

I have a pull request ready to fix this, but is the current behavior by design?

adamhartford pushed a commit to adamhartford/omnisharp-vscode that referenced this issue Jun 6, 2017
@DustinCampbell DustinCampbell added this to the 1.11 milestone Jun 6, 2017
DustinCampbell added a commit that referenced this issue Jun 6, 2017
Fix Restore Packages command when targeting .NET Framework. Issue #1507.
@DustinCampbell
Copy link
Member

This fix will appear in our first 1.11 beta.

@DustinCampbell
Copy link
Member

Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants