Add nag message when project.json projects are opened #1657
Conversation
| utils.requestWorkspaceInformation(server) | ||
| .then(workspaceInfo => { | ||
| if (workspaceInfo.DotNet && workspaceInfo.DotNet.Projects.length > 0) { | ||
| const shortMessage = 'project.json is no longer a supported project format for .NET Core applications.'; |
There was a problem hiding this comment.
You have MSWord style quotes in this string. Expected?
There was a problem hiding this comment.
Hmm... I'm not spotting them
There was a problem hiding this comment.
Sorry, somehow got this comment on the wrong line. See ‘dotnet migrate’.
There was a problem hiding this comment.
FWIW, my phone was hiding them and printing normal quotes. Good catch!
| disposables.push(server.onServerStart(() => { | ||
| utils.requestWorkspaceInformation(server) | ||
| .then(workspaceInfo => { | ||
| if (workspaceInfo.DotNet && workspaceInfo.DotNet.Projects.length > 0) { |
There was a problem hiding this comment.
Will this fire for the old PCL projects that use project.json for dependencies but still have a .csproj? Do you want to deprecate those as well?
There was a problem hiding this comment.
No. Just for project.json files that are handled as projects.
|
The one thing that is a little problematic with this is if you use VS Code to develop Azure Functions. It is somewhat of a very niche use case I guess. |
|
Yeah, I realize this is going to be a bit ugly to roll out. Do Azure Functions actually use project.json for a 'project'? That is, does the OmniSharp DotNetProjectSystem create a project in the OmniSharpWorkspace for them? If not, this won't affect that. |
|
yeah so technically we don't even officially support Azure Functions CSX yet (see OmniSharp/omnisharp-roslyn#779) From the technical standpoint, on the OmniSharp side, it would mean that actually both Dotnet (since that kicks in autoamtically for |
|
I wouldn't expend a ton of effort trying to support Azure Functions based on project.json just yet. Note that there are good reasons to stop proliferating project.json and the latest Azure Functions support for VS 2017 doesn't use them (https://blogs.msdn.microsoft.com/webdev/2017/05/10/azure-function-tools-for-visual-studio-2017/). |
No description provided.