[WIP] Cake support #1681
[WIP] Cake support #1681
Conversation
package.json
Outdated
| @@ -460,13 +462,11 @@ | |||
| "razor" | |||
| ] | |||
| }, | |||
| "runtime": "node", | |||
There was a problem hiding this comment.
You don't want this change
There was a problem hiding this comment.
Oh, are VSCode adding these changes automatically? Can't remember changing these.
There was a problem hiding this comment.
Yes, this happens when you debug the extension.
package.json
Outdated
| "runtimeArgs": [], | ||
| "variables": { | ||
| "pickProcess": "csharp.listProcess", | ||
| "pickRemoteProcess": "csharp.listRemoteProcess" | ||
| }, | ||
| "program": "./out/src/coreclr-debug/proxy.js", |
package.json
Outdated
| }, | ||
| "linux": { | ||
| "program": "./.debugger/vsdbg-ui" | ||
| } | ||
| }, |
package.json
Outdated
| @@ -1387,13 +1396,11 @@ | |||
| "razor" | |||
| ] | |||
| }, | |||
| "runtime": "node", | |||
package.json
Outdated
| "runtimeArgs": [], | ||
| "variables": { | ||
| "pickProcess": "csharp.listProcess", | ||
| "pickRemoteProcess": "csharp.listRemoteProcess" | ||
| }, | ||
| "program": "./out/src/coreclr-debug/proxy.js", |
package.json
Outdated
| "program": "./.debugger/vsdbg-ui" | ||
| }, | ||
| "linux": { | ||
| "program": "./.debugger/vsdbg-ui" |
|
@mholo65 was there something in particular that you thought was "wrong" with this PR? The changes look good to me. 👍 |
|
@gep13 well if we could figure out why we have to change language mode from
|
I posted how that happens in the #cake channel on Slack. The file types that trigger "csharp" as the language is defined in VS Code itself right here. I'll submit a change to add "*.cake" to this list on your behalf today. |
Yes, I saw that in the Slack channel, and that is why I raised this issue #1684, I was trying to get clarity on whether the syntax highlighting that we provide for .cake files would be affected by making that change. Do you know if this will be the case? |
|
Yes, the syntax highlighting for .cake files would be affected. What differences does Cake add to C# syntax highlighting? Note that the official C# support for cake highlighting is here: https://github.com/dotnet/csharp-tmLanguage. |
|
I think this is generally a problem of trying to spread Cake support across two extensions. If you're trying to have a Cake Support extension provide syntax highlighting and the C# extension, I'm less comfortable with taking this change. |
|
Cake is really just C# script with some semantic differences, correct? If that's the case, I would proposal that the Cake Support extension doesn't provide it's own syntax highlighting, but takes advantage of C#'s. Then, the Cake Support extension would be modified to operate on the "csharp" language but only when the extension is ".cake". Thoughts? |
|
I'm going to go ahead and move this conversation over to #1684. |
|
This looks good. Sorry for the delay! |
|
WOO HOO! Thanks for merging this! |
Adding support for Cake (I think). Honestly, I have no idea what I'm doing 😄 @gep13 This needs some TypeScript love from you.
OmniSharp-Roslyn PR here OmniSharp/omnisharp-roslyn#932
NB! For some reason, you'll have to switch language mode from
CaketoC#(If you have Cake VS Code Extension installed) to get intellisense.