Refactoring status using rxjs #2133

akshita31 · 2018-03-23T21:32:41Z

Fixes: #2146
Changes introduced:

Removed status.ts and divided it into 4 observers:

InformationMessageObserver
WarningMessageObserver
ProjectStatusObserver
OmnisharpStatusBarObserver
Each of these observers handles a separate responsibility

The extension was popping up a single statusBarItem which showed both the OmnisharpServerStatus and the status of the currently open project in the workspace. We have now made two separate status bar items for these.
The adding of the listeners and the corresponding disposables for the events like - OnServerStart, OnServerStop, ProjectAdded, etc (done previously in status.ts) are now handled directly in server.ts.
For the events in which a project changes, specifically- ProjectAdded, ProjectRemoved and ProjectChange the updateTracker listener is being used to debounce the update project request using rx debounce( We need the debounce with leading: true, so the logic with updateTracker is implemented so that the first request will always be serviced and the corresponding requests are debounced)
The logic where the status bar depended on the ActiveTextEditor has been removed because we intend the status bar to be a workspace element and not depending on the currently opened document.
OmnisharpStatusBarObserver deals with all the Omnisharp events like Server Start, Server Stop, Install, etc. The corresponding status bar element has been moved to the left side of the editor window. It is a clickable object and on click will show the Omnisharp Log channel.

ProjectStatusBarObserver deals with the project that has been selected and displays the name of the currently selected project or the "Select Project" option if there are multiple launch targets. Clicking this will provide the user the option to pick projects from the Command Palette. The "folder" icon is used to represent this element as shown below.

When a server stop event is created both these status bars are reset and hidden.

Corresponding tests have also been added for the observers.

rchande · 2018-03-23T22:47:47Z

src/main.ts

+    let informationMessageObserver = new InformationMessageObserver(getConfiguration, showInformationMessage, workspaceAsRelativePath);
+    eventStream.subscribe(informationMessageObserver.post);
+
+    let omnisharpStatusBar = new StatusBarItemAdapter(vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right, Number.MIN_VALUE));


I wonder if there's something we could do to avoid having to create a closure to all the "real" vscode implementations. Maybe some kind of "vscode adapter"?

rchande · 2018-03-23T22:52:43Z

src/observers/OmnisharpServerStatusObserver.ts

+    private subject: Subject<ObservableEvent.BaseEvent>;
+
+    constructor(private showWarningMessage: ShowWarningMessage<MessageItemWithCommand>, private executeCommand: ExecuteCommand<string>, scheduler?: Scheduler) {
+        this.subject = new Subject<ObservableEvent.BaseEvent>();


In the future, when we add an option to suppress this message, which component will be responsible for reading the option?

The observer owns projecting the event into vscode, so it will be responsible for interpreting that configuration.

rchande · 2018-03-23T22:56:49Z

src/observers/OmnisharpStatusBarObserver.ts

+    (selector: vscode.DocumentSelector, document: any): number;
+}
+
+export class OmnisharpStatusBarObserver {


It's hard tounderstand from the names how this is different from the thing above it.

rchande · 2018-03-23T22:58:05Z

src/observers/OmnisharpStatusBarObserver.ts

+                this.render();
+                break;
+            case ObservableEvent.ActiveTextEditorChanged.name:
+                this.render();


What does it mean to call render without setstatus? Blank the status bar?

The Status class is a wrapper around the StatusBarItem. There are two possible values that we might display in the StatusBarItem object - defaultStatus or projectStatus. On calling render we check whether any of those values are set for the class and if they are then we display them according to some logic.

rchande · 2018-03-23T22:58:47Z

src/observers/OmnisharpStatusBarObserver.ts

+    }
+
+    private updateProjectInfo = (server: OmniSharpServer) => {
+        serverUtils.requestWorkspaceInformation(server).then(info => {


This method looks like a copypasta from somewhere?

We have removed the status.ts and moved its functionality across three files and this is one of them.

rchande · 2018-03-23T23:05:35Z

src/observers/OmnisharpStatusBarObserver.ts

+        let document = activeTextEditor.document;
+        let status: Status;
+
+        if (this.projectStatus && this.match(this.projectStatus.selector, document)) {


I don't understand what this does. What is match?

These delegates are kind of confusing.

Maybe there could be an observer that sits at the VS Code layer and doesn't take delegates? Of course, it would only be integration test-able.

TheRealPiotrP · 2018-03-24T01:40:31Z

src/features/status.ts

@@ -1,270 +0,0 @@
-/*---------------------------------------------------------------------------------------------


@DustinCampbell :D :D

TheRealPiotrP · 2018-03-24T01:43:54Z

src/observers/OmnisharpServerStatusObserver.ts

+    private subject: Subject<ObservableEvent.BaseEvent>;
+
+    constructor(private showWarningMessage: ShowWarningMessage<MessageItemWithCommand>, private executeCommand: ExecuteCommand<string>, scheduler?: Scheduler) {
+        this.subject = new Subject<ObservableEvent.BaseEvent>();


subject is not a very informative name here.

TheRealPiotrP · 2018-03-24T01:47:08Z

src/observers/OmnisharpServerStatusObserver.ts

+    public post = (event: ObservableEvent.BaseEvent) => {
+        switch (event.constructor.name) {
+            case ObservableEvent.OmnisharpServerOnError.name:
+                this.subject.onNext(event);


Maybe this.projectErrorDebouncer.onNext(...)?

I renamed it as warningMessageDeboucer. Does that seem alright ?

TheRealPiotrP · 2018-03-24T01:48:34Z

src/observers/OmnisharpServerStatusObserver.ts

@@ -0,0 +1,55 @@
+/*---------------------------------------------------------------------------------------------


How about we call this the ShowWarningMessageObserver?

TheRealPiotrP · 2018-03-24T01:50:25Z

src/omnisharp/loggingEvents.ts

-export class OmnisharpServerUnresolvedDependencies implements BaseEvent{
-    constructor(public unresolvedDependencies: protocol.UnresolvedDependenciesMessage) { }
+export class OmnisharpServerUnresolvedDependencies implements BaseEvent {
+    constructor(public unresolvedDependencies: protocol.UnresolvedDependenciesMessage, public server: OmniSharpServer, public eventStream: EventStream) { }


This change is temporary, right? We'll get rid of the extra parameters soon?

Yes we will use the vscode api's to do the restore then we can get rid of this here.

TheRealPiotrP · 2018-03-24T01:51:39Z

src/omnisharp/server.ts

                return;
            }
        }

-        this.eventStream.post(new OmnisharpInitialisation(new Date(), solutionPath));
+        this.eventStream.post(new ObservableEvents.OmnisharpInitialisation(new Date(), solutionPath));


Why do we need to add the ObservableEvents specifier everywhere? It makes the code much more busy..

The import from logging events was becoming too long so I changed that to import * as ObservableEvents from loggingEvents . What do you think is better ?

colombod · 2018-04-05T15:06:49Z

Looks good to me

rchande

Looks pretty good, some questions.

rchande · 2018-04-05T15:35:24Z

src/observers/InformationMessageObserver.ts

+import * as ObservableEvent from "../omnisharp/loggingEvents";
+import { vscode } from '../vscodeAdapter';
+
+export class InformationMessageObserver {


Why does the info message observer not need to debounce when the warning one does?
Also, why is there not an error message observer (maybe it was added in another PR)?

Generally, it seems like we might be painting ourselves into a corner here. If for some reason, we want to be able to configure the errorlevel of a message, we now have to go teach each error level observer how to print that message. Maybe it would be clearer to only have one WindowPostMessageObserverThingy and have it know how to translate event -> VS Code Warning level?

The error event and MSbuildDiagnostics event shows the warning message hence they are both present in the warning message observer

rchande · 2018-04-05T15:39:58Z

src/observers/WarningMessageObserver.ts

+
+    constructor(private vscode: vscode, scheduler?: Scheduler) {
+        this.warningMessageDebouncer = new Subject<BaseEvent>();
+        this.warningMessageDebouncer.debounce(1500, scheduler).subscribe(async event => {


We've gotten feedback that having a ton of these messages appear is annoying. The command we have here doesn't appear to scroll the output to a specific location. Instead of "Debounce", should we change this observer to just raise one notification if it gets that event?

But if the server restarts then ?

Ah, this was me misunderstanding debouce. Looks good to me.

rchande · 2018-04-05T15:41:01Z

src/omnisharp/server.ts

    private _readLine: ReadLine;
-    private _disposables: vscode.Disposable[] = [];
+    private _disposables: CompositeDisposable = new CompositeDisposable(Disposable.empty);


We are trying to remove the dependency on vscode wherever possible. So here we are using the Rx disposables instead.

I meant, why is this initialized to a empty composite disposable when line 286 replaces it with a real disposable?

Yes, you are right. Removed the empty initialization.

rchande · 2018-04-05T15:48:37Z

src/omnisharp/server.ts

-            this._disposables.pop().dispose();
+    // we could move this to a project updated observer and pass the server there. But we will need the event stream also there :(
+    private updateTracker = () => {
+        if (this.firstUpdateProject) {


I don't really understand what this is trying to? The first time, it just sends the message, but subsequent project updates are debounced?

The first time when we get one of the three events - onProjectAdded , onProjectChanged and onProjectRemoved , the updateProjectInfo function is invoked directly. After this if we get any of the events, then we invoke the updateProjectInfo function via the debouncer. This is the functional equivalent of lodash.debounce with leading: true - https://css-tricks.com/debouncing-throttling-explained-examples/#article-header-id-1

What's the consequence if you always debounce? The first message is delayed by debounce interval?

If we keep getting the request then the status bar will not be displayed until there is a silence of 1500 ms. This way with leading true, we service the first request that we get so status bar shows something, and then when for the next requests we see a silence of 1500ms then we service them. Basically it is just so that we have something to display for the first time.

Can you remind me what actual status/message this is displaying? If we can make this code simpler and the consequence is that a message gets delayed by 1.5 seconds, I would be in favor of that. Up to you though...

rchande · 2018-04-05T15:49:12Z

src/omnisharp/server.ts

@@ -84,12 +85,17 @@ export class OmniSharpServer {

    private _omnisharpManager: OmnisharpManager;
    private eventStream: EventStream;
+    private updateProjectDebouncer: Subject<ObservableEvents.ProjectModified>;
+    private firstUpdateProject: boolean;


Just initialize this here.

rchande · 2018-04-05T15:49:35Z

src/omnisharp/server.ts

-
-        while (this._disposables.length) {
-            this._disposables.pop().dispose();
+    // we could move this to a project updated observer and pass the server there. But we will need the event stream also there :(


I don't understand this comment, but I agree with the :(

Sorry I had added in while working but forgot to delete :(

rchande

Thanks for addressing my comments. Also, I just had the opportunity to learn a bunch about how debounce works :).

LGTM

@akshita31

* Initial manual validation plan * Add info about unity * Enable usage of omnisharp.path option for downloading multiple versions of omnisharp (#2028) * Enable usage of multiple versions * Either load the server from a path or download the version packages * Tests for the package creator * Added null check and removed semver check in package creator * Test for the experiment omnisharp downloader * Added test for package manager * Code clean up * Added null or empty check for version * Changes * Modified the description Put the clean up logic in the teardown function * Remove comment * Remove unnecessary usage * CR comments * Removed experimental * Modified launcher * Removed experimental * Modified tests * Modified package description to include version information * Renamed launch path * Add more tests * Changed the description in package.json * "Run All Tests" and "Debug All Tests" (#1961) * Run All Tests Running But Building repeatedly * Disposable variable for run all test * Added code for debug all tests * Code Cleaning * Run all Tests running - Better logs required * Run Tests running, all output shown at the end of all the tests * Renamed variable to methodsInClass * Changes for Debug All Tests * Changes for debug tests request * Debug All Tests running * Added common helpers for single test and all test functions * Improved logs for Run All Tests * Changes to get only 1 response for a set of methods * Extracted a common helper to get the test feature * Resolved review comments * Changes to not show this change for legacy projects * Renamed incorrect variable * Removing foreach for proper order of execution * Remove unnecessary import * Do not show the festure for legacy projects * Make hover test run by adding the file in the project (#2058) * Added hover.cs file * Not requiring server restart * Using Structured Documentation for Signature Help and improving Parameter Documentation (#1958) * Structured Documentation in Signature Help * Code clean up * Using only summary of the documentation * Code clean up * Documentation for parameters showing in signature help * Removing unnecesaary import * Using interploated string and fixed spacing * Parameter Documentation using interpolated text * Added tests * Enable download and usage of latest version of omnisharp (#2039) * Enable usage of multiple versions * Either load the server from a path or download the version packages * Tests for the package creator * Added null check and removed semver check in package creator * Test for the experiment omnisharp downloader * Added test for package manager * Code clean up * Added null or empty check for version * Changes * Modified the description * Put the clean up logic in the teardown function * Remove comment * Remove unnecessary usage * CR comments * Removed experimental * Modified launcher * Removed experimental * Modified tests * Modified package description to include version information * Renamed launch path * Add more tests * Changed the description in package.json * Getting latest version info * Refactored code and added tests * Remove unnecessary using * CR comments * Use common function for latest download * Add new line * Resolve binaries on linux * Copy pacakges by value * Renamed experimentalId and some methods * Moved status item out of method and added version to message * Fix typo (#2066) * Fix year in changelog (#2068) Fixed wrong year in changelog * Formatting for better display structure * Move to const fields in server * Make methods private * Move chai-as-promised to devDependencies * Removed unnecessary function * Insert new debugger with support for Symbol Server and Source Link (#2070) * launch.json schema changes and documentation This has the new launch.json schema to support XPlat symbols * Update debugger packages * Update CHANGELOG.md with debugger change * Modified test description * Update .editorconfig JSON rules (#2063) Last week I ran into yet another time when something added a BOM to one of our json files and broke things. This adds some .editorconfig rules for .json to try and prevent such things. While I was at it, I also wanted to switch the indent size for src/tools/*.json to be '2' so that it is consistent with other json schema files the debugger owns. * Updated to reflect limited Desktop CLR support (#2046) * Updated to reflect limited Desktop CLR support * Fixed grammatical error * Refactor CSharpExtDownloader to use the extracted helper functions (#2072) * Refactor downloader * Renamed method and corrected the position of appendLine * Modified GetStatus and the Status object to append the dispose method * Added settings file * Emphasize test codelens * Add another bullet point * Add more details about signature help and tests codelenses * Fix typo * Update Changelog and test-plan for multiple download of omnisharp (#2082) * Update changelog and test-plan for multiple download of omnisharp * Add mocha+wallaby tests (#2091) * Add mocha+wallaby tests eventually the feature tests should be removed and most of our tests should become unit tests that are runnable from the command line or via wallaby. npm run tdd will enable using mocha's command line tdd capability * Fix `tdd` command * Fix test paths * move to tslint-no-unused-expression-chai The package was already installed, but not used. This makes our tests that use chai.should() pass tslint checks * Add Architecture check in AdapterExectuableCommand (#2094) * Add Architecture check in AdapterExectuableCommand x86 messages only show during the first installation. But it still registeres the vsdbg-ui.exe command. This adds a check so it will error instead of returning the command. * Moving arch check into completeDebuggerInstall * Beta1 -> Beta2 * Remove angle brackets in ChangeLog (#2099) * Add product-wide code coverage + codecov.io integration (#2101) Add product-wide code coverage + codecov.io integration Several new scripts were added: npm run cov:instrument: rebuilds your sources, then instruments them for coverage. Subsequent npm run test will generate coverage data into the .nyc_output directory npm run cov:merge-html: merges all reports from .nyc_output and puts a locally viewable coverage report into coverage directory * Refactor logger, reporter and channel into a unified EventStream using Rx Observable (#2084) * Changes to refactor logging in server * Adding packages * Changes * Remove reporter from CSharpExtDownloader * remove telemtery reporter from server.ts * remove reporter from definitionProvider * Remove reporter from dotnetTest.ts * Debugger Activation + Commands * reduce message types * remove reporter from commands.ts * remove channel from status.ts * Remove reporter & logger from extension.ts * Build issues * Add missing rx dependency * Changed to download progress * Removed using and pass platformInfo * Moved files in observer folder * Renamed the files and added omnisharp channel observer * Remove unnecessary format * Changes in main.ts * Remove channel from global declaration * Preserving the context in onNext invocations * Pulled platformInfo out of server * Remove unnecessary variable * Formatting * Renamed observers * Add mocha+wallaby tests eventually the feature tests should be removed and most of our tests should become unit tests that are runnable from the command line or via wallaby. npm run tdd will enable using mocha's command line tdd capability * Code clean up * Fix `tdd` command * Fix test paths * Add initial DotnetChannelObserver test * Testing the download messages * Remove logger from requestQueue.ts * Fix builds * Use package manager factory * Remove Lines * Remove extra appendLine * Added test for csharp logger and channel * Extracted base class for observers * Test having dependency on vscode * vscode adapter changes * Changes for adapter * Refactored Omnisharp Manager * Moved from interfaces to classes * Renamed onNext to post * Created class EventStream * Removed comment * Added missing break * Added test for Omnisharp Logger * Test for OmnisharpLoggerObserver * Test for telemetry reporter observer * Added test for all the observers * minor nits * Changes * Remove unnecessary imports * remove import * Modified failing test * Make tests pass * Renamed platformInfo * CR feedback * 2 -> 3 * Fix codecov integration (#2108) Fix js->ts coverage map transformation in Travis CI where `node` is not on the path. * enable codecov on unit tests (#2118) * enable codecov on unit tests * rename coverage files for uniform globbing * Validate Indentation for OmnisharpProcess messages (#2119) * Clean up signature help test (#2117) * Added parameter * modifications * Cleaned up tests * Changed test codelens casing (#2077) * CodeCov flags (#2125) Lights up integration test coverage and splits reporting data between unit & integration tests * Update project npm dependencies (#2126) * low-risk package updates * high-risk package updates * disable uninstrumented test pass (#2127) * Fix size (#2142) * 1.15.0-beta4 (#2143) * Verify vsix size before release (#2144) * Verify vsix size before release * Remove istanbul from shipping payload * Use the size appropriately in the release test (#2145) * Fix offline packaging using event stream (#2138) * Creating a new eventStream * invokeNode * Artifact tests * Directing the vsix files to a temp folder * Changes to travis to run release tests on release only * if statement * Convert gulpfile to ts * Add bracket * Clean up the observer tests for better readability (#2157) * CsharpLoggerObserver * dotnetchannelobserver * TelemetryObserver * DebugModeObserver * Correct message in the debug observer * Refactoring status using rxjs (#2133) * hack * Refactored status into 4 separate observers * Resolved warning and information messages * Deleted status.ts * Changes to retain this context * Created fascade for statusbar and texteditor * Subscribe to event stream * Working! * Nits * Mocking warning message * Tried mocking setTimeOut * warning message changes * warning message correct definition * virtual time running * done called multiple time * renamed observer and subject * changes * some changes * refactor^2 * merge conflicts * using rx debounce * Warning Message Observer tests * Remove loadsh.debounce and renamed observer * Move the workspace info invocation to server * Clean up * More test to statusBarObserver * Clean up tests * Fixed ttd * Use vscode commands instead of calling into commands.ts * Added test for information message observer * Tests for status bar obsever * project status observer * Changes to show two observers * some more changes * Lot of questions! * build issues * Remove usings * comments * Remove unnecessary cases * Changes * Remove usings * Dipsose the disposables after the server stop event * Remove the cake thing * Project Status Bar * Clean up the tests * Changed to dcoument * Remove unnecessary functions from the adapter * remove unnecessary change * Remove some changes * changes * Test for server error * Removed comment and modified the initialisation * Empty disposable * Corrected the usage of the disposables * Added comments for debouncer * disposable try * Test the vsix, not the build layout (#2156) The VSCode C# Extension build process follows the VS Code docs and runs tests directly inside of its repo root. This unfortunately gives a false sense of security because bugs can be introduced during VSIX packaging [particularly due to missing content in node_modules or excluded via .vscodeignore]. This change addresses this problem by moving our CI tests to execute the VSIX instead of the build's intermediate artifacts. Specifically: build the vsix unpackage the vsix instrument the unpackaged vsix run tests with VS Code Host pointing to the unpackaged vsix This makes our CI tests ~= to the user's runtime experience and will greatly help us with size reduction efforts. To support this change, I also moved our build system from package.json to Gulp. This makes the build scripts significantly easier to understand, provides intellisense for build scripts, and build-time type checking for their contents. I also strengthened the repo's use of .vscodeignore by creating a copy of the file for each scenario [online packages and offline packages]. The new gulp packaging scripts take advantage of these files to produce packages with predictable contents regardless of when packaging occurs. [small caveat, @akshita31 will be adding a test that validates that net-new content does not start sneaking into the vsix package]. * Enable `noImplicitAny` and `alwaysStrict` in `tsconfig.json (#2159) Along the way, fixed a few bugs that were in place due to implicit anys. Also removed dependency on deprecated vscode API. * tsconfig.json: noUnusedLocals, noFallThroughCaseInSwitch, tslint.json: promise-function-async (#2162) Adds noUnusedLocals to tsconfig.json to keep our sources clean Adds noFallThroughCaseInSwitch in tsconfig.json to prevent unintended switch behavior Adds promise-function-async to tslint.json to force all async functions to be marked as async. This is a building block towards eliminating promises in favor of async/await. * Eliminate Thennable<any> (#2163) Provides strong typing for the repo's Thennables. This is a step towards eliminating promises and will provide compiler support for validating that the refactored code has not changed its final return type. * promise to await packaging tasks (#2164) * Remove the status handling from the package manager (#2160) * Changes to remove status from packages.ts * Tests failing * Added tests * Used tooltip and changed flame color * fix merge problems * PR feedback * Removed implicit any * Changes * Update the links to the Source Link spec (#2170) This updates the links we had to the Source Link spec to point at the more official version. * Make the server and the downloader rely on the vscode adapter (#2167) * Moving fakes to testAssets * Change the import for fakes.ts * Test Assets in feature tests * Remove vscode dependency from server.ts * Make the downloading stuff use vscode adapter * Remove vscode as a property * make test package json a field * Run release test only on release (#2172) * Show the channel on download start (#2178) * Add "Launch Unit Test" option (#2180) * unify rx usage to rxjs (#2168) The current codebase uses both rx [v4] and rxjs [v5] implementations. This PR consolidates our use of rx onto the v5 libraries. * Fix disposable (#2189) * Divide the package manager into separate components (#2188) * Feature tests running with refactored package manager * Refactoring packages-1 * Test for the downloader running using the mock server * Using network settings * Changing the package path * Dividing packages.ts into separate components * use filter async * Use tmpfile interface * Check for the event stream * Using FilePathResolver * Remove using * Testing for normal and fallback case working * Resolve the paths * Remove failing case * package installer test-1 * Add package installer test * Create tmp asset * Package Downloader test refactored * Rename files * resolve compile issues * Clean up installer * Clean up the tests * Rename packages * Package installer test * PR feedback * Package Filter test * Remove yauzl.d.ts * Filter test * Added test for invalid zip file * method for getting the request options * remove imports * please resolve the path * remove latest in settings * Package Manager test executing * Use free port in package manager test * Package Manager (using a https server running) * using http mock server * Downloader test running using free port * Update ChangeLog for codelens and status bar (#2205) * PR feedback * Introduce OmniSharpLaunchInfo type * Fix casing of 'OmniSharp' in user-facing error message * Return both 'LaunchPath' and 'MonoLaunchPath' from OmniSharpManager * move back to latest for O# release * Refactor launcher and ensure that we launch on global Mono if possible * Improve coverage a bit * Use async/await in OmniSharpServer._start() * Fix test * Update debugger links for 1.15.0-beta5 This updates the debugger packages to the latest corelr-debug which is now built on .NET Core 2.1 Preview 2. * Update debugger changelog and debugger-launchjson.md for 1.15 (#2230) - Add debugger items to the changelog - Update debugger-launchjson.md to reference the new launchSettings.json feature. * Mark the C# extension as non-preview (#2220) * Mark the C# extension as non-preview This changes the branding on the C# extension so that it is no longer labeled a 'preview'. Two changes: 1. Change `preview` to `false` in package.json 2. Update the license that is used in official builds of the C# extension. This new EULA is no longer a pre-release EULA and it also has the latest text. * Update README.md as well

Piotr Puszkiewicz and others added 14 commits March 19, 2018 16:57

hack

ebdacba

Refactored status into 4 separate observers

955a634

Resolved warning and information messages

1d6934a

Deleted status.ts

980a0c3

Changes to retain this context

356826e

Created fascade for statusbar and texteditor

f3bb9a1

Subscribe to event stream

af75cd7

Working!

7baa259

Nits

f1a02e9

Mocking warning message

bb23931

Tried mocking setTimeOut

93274a7

warning message changes

ad3e810

warning message correct definition

c70bff1

virtual time running

d1cf772

rchande reviewed Mar 24, 2018

View reviewed changes

done called multiple time

4377f68

TheRealPiotrP reviewed Mar 24, 2018

View reviewed changes

TheRealPiotrP force-pushed the statusRefactor branch from 4749cc7 to d1cf772 Compare March 24, 2018 03:19

akshita31 and others added 7 commits March 24, 2018 13:47

renamed observer and subject

cbf33eb

changes

f7f5db9

some changes

11c0d48

refactor^2

1432851

merge conflicts

bbcc1e4

using rx debounce

439b1d1

Merge branch 'statusRefactor' into dev/therealpiotrp/StatusRefactor

4ab302d

akshita31 added 11 commits April 3, 2018 18:40

Merge branch 'master' into statusRefactor

0babb1e

Remove the cake thing

371d24a

Project Status Bar

8694e10

Merge remote-tracking branch 'origin/statusRefactor' into statusRefactor

285f722

Clean up the tests

731053b

Changed to dcoument

dd76b08

Remove unnecessary functions from the adapter

2ee30a0

remove unnecessary change

24d6b0c

Remove some changes

d4ba6be

changes

72a2a1d

Test for server error

06c4f3d

akshita31 requested review from DustinCampbell, TheRealPiotrP, rchande and colombod April 5, 2018 03:14

colombod approved these changes Apr 5, 2018

View reviewed changes

rchande suggested changes Apr 5, 2018

View reviewed changes

akshita31 added 2 commits April 5, 2018 10:37

Removed comment and modified the initialisation

9776f2a

Empty disposable

8382368

rchande approved these changes Apr 5, 2018

View reviewed changes

akshita31 added 4 commits April 5, 2018 14:52

Corrected the usage of the disposables

dfcd44a

Added comments for debouncer

cd231ac

Merge branch 'master' into statusRefactor

b379afd

disposable try

68264b4

akshita31 merged commit 4001e8e into dotnet:master Apr 5, 2018

akshita31 deleted the statusRefactor branch April 5, 2018 23:18

akshita31 mentioned this pull request Apr 20, 2018

Update ChangeLog for codelens and status bar #2205

Merged

NinoFloris mentioned this pull request Sep 30, 2018

Prevent Omnisharp Log opening on startup #2556

Closed

		@@ -1,270 +0,0 @@
		/*---------------------------------------------------------------------------------------------

		@@ -0,0 +1,55 @@
		/*---------------------------------------------------------------------------------------------

Refactoring status using rxjs #2133

Refactoring status using rxjs #2133

Conversation

akshita31 commented Mar 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colombod commented Apr 5, 2018

rchande left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshita31 Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rchande left a comment

Choose a reason for hiding this comment

akshita31 commented Mar 23, 2018 •

edited

Loading

akshita31 Apr 5, 2018 •

edited

Loading