Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging of tests #2337

Merged
merged 4 commits into from
May 24, 2018
Merged

Improve logging of tests #2337

merged 4 commits into from
May 24, 2018

Conversation

akshita31
Copy link
Contributor

Fixes: #2268

After this fix, the output appears as :
----- Running test method "BankTests.UnitTest1.Debit_WithValidAmount_UpdatesBalance" -----

` Microsoft (R) Build Engine version 15.7.179.6572 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

Bank -> c:\Users\Bank\Bank\bin\Debug\Bank.dll
BankTests -> c:\Users\Bank\BankTests\bin\Debug\netcoreapp2.0\BankTests.dll

Build succeeded.
0 Warning(s)
0 Error(s)

Time Elapsed 00:00:01.19

----- Test Execution Summary -----

BankTests.UnitTest1.Debit_WithValidAmount_UpdatesBalance: Failed
Outcome: Failed
Error Message: Assert.AreEqual failed. Expected a difference no greater than <0.001> between expected value <7.7> and actual value <7.44>. Account not debited correctly

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0 `

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #2337 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
+ Coverage    61.2%   61.32%   +0.12%     
==========================================
  Files          85       85              
  Lines        3823     3835      +12     
  Branches      550      552       +2     
==========================================
+ Hits         2340     2352      +12     
  Misses       1313     1313              
  Partials      170      170
Flag Coverage Δ
#integration 51.06% <0%> (-0.14%) ⬇️
#unit 82.71% <100%> (+0.18%) ⬆️
Impacted Files Coverage Δ
src/observers/DotnetTestLoggerObserver.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec919f...9f7b820. Read the comment docs.

@akshita31
Copy link
Contributor Author

@rchande Should we display the error stack trace as well ?

@rchande
Copy link

rchande commented May 24, 2018

@akshita31 Yes, that would be good.

@akshita31 akshita31 added this to the 1.16 milestone May 24, 2018
@akshita31 akshita31 merged commit 4be8950 into dotnet:master May 24, 2018
@akshita31 akshita31 deleted the improve_logging branch May 24, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests doesn't provide any output
2 participants