Do not steal the focus when showing the channels #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshita31
force-pushed
the
do_not_steal_focus
branch
from
cfba535
to
885c103
Compare
rchande
approved these changes
Jan 28, 2019
| observer = new OmnisharpChannelObserver({ | ||
| ...getNullChannel(), | ||
| show: () => { hasShown = true; }, | ||
| show: (preserve) => { |
There was a problem hiding this comment.
Is there a case where we want to steal the focus
There was a problem hiding this comment.
As of now I couldnt think of any particular case hence right now we are using true everywhere
There was a problem hiding this comment.
Why not make it even easier and remove the paramter/always pass true in this method?
Codecov Report
@@ Coverage Diff @@
## master #2828 +/- ##
==========================================
- Coverage 65.12% 65.06% -0.06%
==========================================
Files 104 104
Lines 4505 4503 -2
Branches 657 657
==========================================
- Hits 2934 2930 -4
- Misses 1386 1387 +1
- Partials 185 186 +1
Continue to review full report at Codecov.
|
akshita31
force-pushed
the
do_not_steal_focus
branch
from
885c103
to
dd1b636
Compare
|
this is great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2756