-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use webpack to reduce the code loading times #2835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2835 +/- ##
===========================================
+ Coverage 64.87% 86.15% +21.28%
===========================================
Files 104 58 -46
Lines 4501 1589 -2912
Branches 657 206 -451
===========================================
- Hits 2920 1369 -1551
+ Misses 1395 165 -1230
+ Partials 186 55 -131
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2835 +/- ##
==========================================
+ Coverage 64.87% 87.17% +22.3%
==========================================
Files 104 59 -45
Lines 4501 1739 -2762
Branches 657 206 -451
==========================================
- Hits 2920 1516 -1404
+ Misses 1395 168 -1227
+ Partials 186 55 -131
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great job in size reduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work--thanks!
This PR enables the usage of webpack to bundle the extension, so that the corresponding js produced and the code load times are lesser, to fix issues like : #2817, #2757.
gulp vsix:release:unpackage
step and also the --codeExtensionPath flag being passed to the gulp tasks.Also, this PR updates the vscode tasks to version 2.0.