Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover consistency with Visual Studio #3090

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Conversation

paladique
Copy link
Contributor

Fixes #2610

I also changed the display order so that it looks similar to VS's behavior:

image

@rchande
Copy link

rchande commented May 31, 2019

@paladique Thanks for the PR! LGTM
cc @akshita31

@paladique
Copy link
Contributor Author

Looks I need to fix a test too! Working on that now.

@rchande
Copy link

rchande commented May 31, 2019

@paladique Note that you also need to update

1) Hover Provider: single csproj at root of workspace
       Hover returns structured documentation with proper newlines:

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #3090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3090   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          59       59           
  Lines        1588     1588           
  Branches       89       89           
=======================================
  Hits         1426     1426           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2edb94...b106795. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #3090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3090   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          59       59           
  Lines        1588     1588           
  Branches       89       89           
=======================================
  Hits         1426     1426           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ae7f7...52f7bbb. Read the comment docs.

@akshita31
Copy link
Contributor

@paladique Thank you for your contribution. Looks good to me :)

@akshita31
Copy link
Contributor

@rchande Should we have a changelog entry for this ?

@akshita31 akshita31 merged commit bdeeab9 into dotnet:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hover experience consistent with Visual Studio
3 participants